Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Marine VRFY Task in the SOCA ctests #856

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix Marine VRFY Task in the SOCA ctests #856

merged 3 commits into from
Jan 17, 2024

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Jan 17, 2024 •
edited
Loading

What this PR includes:

  • Fix test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY

by updating marine_gdas_plots.yaml format and it related marine_eva_post.py

  • As of now, ctests passed on Hera Machine and Orion Machine is still needed to check
  • ctests passed on both Hera Machine and Orion Machine, see Fix marine vrfy job #829

Fixes #829

Thanks to @CoryMartin-NOAA

RussTreadon-NOAA
RussTreadon-NOAA approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the key was to add figure list. I don't know eva well enough to know if this is correct. Since it worked on Hera, I assume it's correct.

Approve pending confirmation that the proposed changes work on Hera and Orion. FYI, we can also run GDASApp on Hercules but this platform is not yet part of GDASApp CI.

@apchoiCMD
Copy link
Collaborator Author

Looks like the key was to add figure list. I don't know eva well enough to know if this is correct. Since it worked on Hera, I assume it's correct.

Approve pending confirmation that the proposed changes work on Hera and Orion. FYI, we can also run GDASApp on Hercules but this platform is not yet part of GDASApp CI.

Thanks for the quick reply and information you provide. I will update it once tests on Orion is done.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jan 17, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jan 17, 2024
@emcbot
Copy link

emcbot commented Jan 17, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jan 17 19:25:23 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jan 17 20:12:20 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jan 17 22:04:51 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 52

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 17, 2024
@emcbot
Copy link

emcbot commented Jan 17, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Jan 17 13:19:55 CST 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jan 17 14:24:18 CST 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jan 17 16:09:38 CST 2024
Tests: 100% tests passed, 0 tests failed out of 52

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 17, 2024
@apchoiCMD apchoiCMD marked this pull request as ready for review January 17, 2024 22:10
@ShastriPaturi
Copy link
Collaborator

@apchoiCMD VRFY ctest fails on orion for me.

guillaumevernieres
guillaumevernieres approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out @apchoiCMD and @RussTreadon-NOAA !

@guillaumevernieres guillaumevernieres merged commit f63fe7e into develop Jan 17, 2024
5 checks passed
@RussTreadon-NOAA
Copy link
Contributor

Thanks for sorting this out @apchoiCMD and @RussTreadon-NOAA !

Credit goes to @apchoiCMD for getting VRFY working again. I simply noted the failure.

@apchoiCMD
Copy link
Collaborator Author

Thanks for sorting this out @apchoiCMD and @RussTreadon-NOAA !

Credit goes to @apchoiCMD for getting VRFY working again. I simply noted the failure.

Everyone gets credits while working together- @RussTreadon-NOAA and the hidden helper was @CoryMartin-NOAA , thanks to everyone for helping me.

@apchoiCMD apchoiCMD deleted the bugfix/soca_vrfy branch February 5, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@ShastriPaturi ShastriPaturi Awaiting requested review from ShastriPaturi

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix marine vrfy job
5 participants
@apchoiCMD @emcbot @ShastriPaturi @RussTreadon-NOAA @guillaumevernieres